Repository navigation
Fix storage private endpoint names - #157
Open
Andy Jordan (andyleejordan) wants to merge 1 commit into
Open
Andy Jordan (andyleejordan) wants to merge 1 commit into
Andy Jordan (andyleejordan) wants to merge 1 commit into
Conversation
Use the endpoint string directly instead of indexing it. Add blob and file private endpoint fixtures for the previously untested path. Drafted by Copilot with GPT-6.1 Sol. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Closed
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
A development build of Bicep from
main(6f783fb4a0) exposed an existing storage module bug:endpointis already'blob'or'file', so indexing it with[0]produces BCP076. Use the string directly in both names and cover blob/file private endpoints in the existing test fixture.Validation: the fixture fails without the fix and compiles with it; Azure PSRule checks pass (431 results). OSS checks report three pre-existing missing license headers, unchanged here.
Relates to Azure/bicep#20552.
PR Checklist
Drafted by Copilot with GPT-6.1 Sol.